Skip to content

feat(stovepipe): add request history protobuf contract - #638

Open
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-history-apifrom
mnoah1/stovepipe-request-history-proto
Open

feat(stovepipe): add request history protobuf contract#638
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-history-apifrom
mnoah1/stovepipe-request-history-proto

Conversation

@mnoah1

@mnoah1 mnoah1 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Expose a stable, queue-scoped contract for reading complete retained request history.
  • Match SubmitQueue public response shapes while keeping internal persistence modeled as a request log.

Changes:

  • Return ordered HistoryEvent values directly from request-ID lookup.
  • Return repeated RequestHistory values from URI lookup; each contains only request_id and ordered events.
  • Leave URI, build strategy, and base URI on the independently resolvable Request.
  • Leave validation degree in internal metadata; the initial proto has no ValidationResult projection.
  • Regenerate the gRPC and YARPC bindings from the aligned contract.

This PR builds directly on #634.

Test Plan

  • ./tool/bazel test //api/stovepipe/... //service/stovepipe/... //stovepipe/...
  • make lint
  • make check-tidy
  • make check-gazelle

Revert Plan

Revert this PR; the request-history RFC remains independently reviewable in #634.

Jira Issues

None.

@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-proto branch from 981f4f1 to 348b7e3 Compare August 27, 2026 15:14
@mnoah1
mnoah1 changed the base branch from mnoah1/stovepipe-get-validation-api to mnoah1/stovepipe-history-api August 27, 2026 15:14
@mnoah1
mnoah1 marked this pull request as ready for review August 27, 2026 15:18
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners August 27, 2026 15:18
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-proto branch from 348b7e3 to 73724a8 Compare August 31, 2026 16:28
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-proto branch 2 times, most recently from 787296a to 1b083b2 Compare August 31, 2026 17:19
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-proto branch from 1b083b2 to c66766b Compare August 31, 2026 22:21
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-proto branch 2 times, most recently from 580169a to cd9c689 Compare August 31, 2026 22:52
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-proto branch from cd9c689 to 9d86a83 Compare August 31, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant